Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update id for ignoring path-to-regexp advisory #27044

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Sep 10, 2024

Description

Follow up to #27024 and #27041

The id has changed again, so we are going to try updating one more time.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested a review from a team as a code owner September 10, 2024 17:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@danjm danjm changed the title Update id for ignoring path-to-regexp advisory fix: Update id for ignoring path-to-regexp advisory Sep 10, 2024
@danjm danjm merged commit 7dc6362 into develop Sep 10, 2024
83 of 85 checks passed
@danjm danjm deleted the fix-audit-again branch September 10, 2024 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 10, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [fc63054]
Page Load Metrics (1900 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31124261828413198
domContentLoaded15612355188220799
load156924351900222107
domInteractive146938168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
@metamaskbot metamaskbot added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.3.0 on PR. Adding release label release-12.3.0 on PR and removing other release labels(release-12.5.0), as PR was cherry-picked in branch 12.3.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants