fix: flaky test Swap Eth for another Token @no-mmi Completes a Swap between ETH and DAI after changing initial rate

[seaona]

Description

This test is fetching the swap quote to the live server, instead of using mocks. This can cause the test to be unstable, if the response takes too long.

The error appears when then the quotes timer is reset and we cannot find the 0:25 element (as we are around 0:46s)

TimeoutError: Waiting for element to be located By(xpath, .//*[./@data-testid = 'countdown-timer__timer-container'][(contains(string(.), '0:25') or contains(string(.), '0:25'))]).

Related issues

Fixes: #27023

Manual testing steps

1. Check ci

Screenshots/Recordings

The swap request for quotes is not mocked, taking a non-deterministic time to get a response, hence making the test unstable.
See for example, this case, where the request took almost 3 seconds to resolve:

swap-quote-not-mocked.mp4

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [2b76ae3]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1743 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	242	2485	1610	509	245
		domContentLoaded	1502	2258	1714	188	90
		load	1513	2382	1743	212	102
		domInteractive	13	135	39	28	14

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)