Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test Change assets changes to native currency when switching accounts during a NFT send #27014

Closed
wants to merge 3 commits into from

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 10, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona added flaky tests area-qa Relating to QA work (Quality Assurance) labels Sep 10, 2024
@seaona seaona self-assigned this Sep 10, 2024
@seaona seaona requested a review from a team as a code owner September 10, 2024 08:22
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@seaona
Copy link
Contributor Author

seaona commented Sep 10, 2024

the way the gas is calculated is not predictable, and depending on where and how we add delays, we get ones results or others in the different builds (chrome /ff / webpack). thus there is not an easy way to fix this on the testing side

@seaona seaona closed this Sep 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant