Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky test 'Import NFT should continue to display an imported NFT after importing, adding a new account, and switching back #27006

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 10, 2024

Description

In this test, we are importing an NFT and right after, we try to switch accounts. Sometimes, when we try to click into the Account, we get an error that another element is obscuring it.
To fix it, when we click confirm, for importing the NFT, we'll wait until the element disappears, after proceeding to clicking the Account.

ElementClickInterceptedError: Element <button class="mm-box mm-text mm-button-base mm-button-base--size-sm mm-button-base--ellipsis multichain-account-picker mm-text--body-md-medium mm-text--ellipsis mm-box--padding-0 mm-box--padding-right-2 mm-box--padding-left-2 mm-box--display-inline-flex mm-box--gap-2 mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default mm-box--background-color-transparent mm-box--rounded-lg"> is not clickable at point (576,112) because another element <div class="mm-box mm-box--display-flex mm-box--justify-content-space-between mm-box--align-items-flex-end"> obscures it

Open in GitHub Codespaces

Related issues

Fixes: #27005

Manual testing steps

  1. Check ci

Screenshots/Recordings

See how the NFT modal is the element obscuring the Account menu, with the selector <div class="mm-box mm-box--display-flex mm-box--justify-content-space-between mm-box--align-items-flex-end">

Screenshot from 2024-09-10 08-07-07

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona self-assigned this Sep 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added flaky tests area-qa Relating to QA work (Quality Assurance) labels Sep 10, 2024
Copy link

@seaona seaona marked this pull request as ready for review September 10, 2024 06:08
@seaona seaona requested a review from a team as a code owner September 10, 2024 06:08
@metamaskbot
Copy link
Collaborator

Builds ready [10b6305]
Page Load Metrics (1674 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint21422881488531255
domContentLoaded15022279166317685
load15112291167417785
domInteractive137932178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona merged commit 646aac4 into develop Sep 10, 2024
107 of 108 checks passed
@seaona seaona deleted the fix-flaky-import-nft-acct branch September 10, 2024 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 10, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Import NFT should continue to display an imported NFT after..." flaky tests
5 participants