Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for AddNetworkModal component #27003

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 9, 2024

This PR adds a Storybook story for the AddNetworkModal component. The story showcases different states and configurations of the component, improving its testability and documentation.

  1. Reason for the change: To enhance the component's visibility in Storybook and facilitate easier testing and development.
  2. Improvement/solution: Created a new story file with multiple variations of the AddNetworkModal component.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the AddNetworkModal component in the Pages/Onboarding folder.

Screenshots/Recordings

Screenshot 2024-09-09 at 4 24 18 PM

Pre-merge author checklist

  • I've followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This Devin run was requested by George.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested review from a team as code owners September 9, 2024 22:30
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6cba3ba]
Page Load Metrics (1833 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23022051679499240
domContentLoaded14832153180518890
load14912203183319895
domInteractive13145372813
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension team-ai AI team (for the Devin AI bot) labels Sep 9, 2024
@georgewrmarshall georgewrmarshall force-pushed the devin/story-addnetworkmodal branch 2 times, most recently from 0c6a0ed to f822c8b Compare September 9, 2024 23:22
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Viewed storybook locally ✅

@metamaskbot
Copy link
Collaborator

Builds ready [53c32b7]
Page Load Metrics (1546 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13691817155012058
domContentLoaded13641809152711455
load13671820154612158
domInteractive116424115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [afeaae2]
Page Load Metrics (2093 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26424301859664319
domContentLoaded17862368205518689
load18032426209319393
domInteractive168041168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Sep 10, 2024

SonarCloud Code Analysis can be ignored. This is a story and doesn't require testing coverage

@georgewrmarshall georgewrmarshall merged commit ddc0d58 into develop Sep 10, 2024
76 of 78 checks passed
@georgewrmarshall georgewrmarshall deleted the devin/story-addnetworkmodal branch September 10, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 10, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants