Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Data collection does not appear on Settings search #26953

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Sep 5, 2024

Description

Fixes an issue where the Data Collection setting isn't displaying in search results.

Open in GitHub Codespaces

Related issues

Fixes: #25627

Manual testing steps

  1. Go to settings
  2. Search for "Data coll"
  3. See the search result
  4. Click the result takes you to the bottom of Security settings

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner September 5, 2024 21:37
Copy link
Contributor

github-actions bot commented Sep 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarqubecloud bot commented Sep 6, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [9b0d308]
Page Load Metrics (1653 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22420681570348167
domContentLoaded14022059163216780
load14102068165317785
domInteractive11209514924
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 229 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.17%. Comparing base (8ffbb54) to head (9b0d308).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
ui/helpers/constants/settings.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26953   +/-   ##
========================================
  Coverage    70.17%   70.17%           
========================================
  Files         1425     1425           
  Lines        49647    49655    +8     
  Branches     13889    13890    +1     
========================================
+ Hits         34836    34843    +7     
- Misses       14811    14812    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down and works great. LGTM✅

Copy link
Contributor

@jonybur jonybur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me

@darkwing darkwing merged commit ce8d495 into develop Sep 11, 2024
78 checks passed
@darkwing darkwing deleted the 25627-data-collection-settings-search branch September 11, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 11, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Settings - Data collection does not appear on Settings search
4 participants