Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge-queue-test-1 #26901

Merged
merged 2 commits into from
Sep 4, 2024
Merged

chore: merge-queue-test-1 #26901

merged 2 commits into from
Sep 4, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Sep 4, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr requested a review from a team as a code owner September 4, 2024 14:15
Copy link
Contributor

github-actions bot commented Sep 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarqubecloud bot commented Sep 4, 2024

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (3c07960) to head (fe0a8c5).

Additional details and impacted files
@@                Coverage Diff                @@
##           merge-queue-test   #26901   +/-   ##
=================================================
  Coverage             70.14%   70.14%           
=================================================
  Files                  1424     1424           
  Lines                 49572    49572           
  Branches              13868    13868           
=================================================
  Hits                  34769    34769           
  Misses                14803    14803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [fe0a8c5]
Page Load Metrics (1955 ± 154 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23832441801605290
domContentLoaded172230201921276132
load175932551955320154
domInteractive147632147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Sep 4, 2024
Merged via the queue into merge-queue-test with commit 0a0b3b5 Sep 4, 2024
76 checks passed
@itsyoboieltr itsyoboieltr deleted the merge-queue-test-1 branch September 4, 2024 16:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants