Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Typography with Text component in nfts-items.js #26731

Closed
wants to merge 1 commit into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Aug 28, 2024

Description

This pull request is part of the ongoing effort to update typography across the MetaMask extension. Specifically, it migrates the nfts-items.js component from using the deprecated Typography component to the new Text component from the component library.

The main changes include:

  1. Replacing import of Typography with Text from component-library
  2. Updating all instances of Typography component to Text component
  3. Replacing TypographyVariant with TextVariant
  4. Updating props like fontWeight, fontStyle, textAlign to match new Text component API

These changes improve consistency across the codebase and align with the new design system.

Devin Run Link: https://preview.devin.ai/devin/471329896efd4e8583e512adae22093d

Open in GitHub Codespaces

Related issues

Partially Fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the NftsItems component
  3. Verify that the component renders correctly with the new Text components
  4. Check that all text elements maintain their previous styling and layout

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I've followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Extension team-ai AI team (for the Devin AI bot) labels Aug 29, 2024
@georgewrmarshall georgewrmarshall deleted the devin/typography-Gyi branch September 6, 2024 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
1 participant