feat: Adding context to get current confirmation PR-6 #26685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26685 +/- ##
===========================================
- Coverage 70.15% 70.15% -0.00%
===========================================
Files 1425 1425
Lines 49647 49653 +6
Branches 13890 13893 +3
===========================================
+ Hits 34828 34832 +4
- Misses 14819 14821 +2 ☔ View full report in Codecov by Sentry. |
Builds ready [231ab8e]
Page Load Metrics (72 ± 7 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
matthewwalsh0
previously approved these changes
Aug 30, 2024
| const processAction = useConfirmationAlertActions(); | ||
| setConfirmationAlerts(); | ||
|
|
||
| return ( | ||
| <AlertMetricsProvider> | ||
| <AlertMetricsProvider | ||
| metrics={{ |
There was a problem hiding this comment.
Great spot, there could be alternate systems in future using the alert metrics that won't want to add metrics to transactions and signatures.
| @@ -1,17 +1,26 @@ | |||
| import React, { createContext, useContext, ReactNode, useMemo } from 'react'; | |||
| import { useConfirmationAlertMetrics } from '../../../../pages/confirmations/hooks/useConfirmationAlertMetrics'; | |||
|
|
|||
| const AlertMetricsContext = createContext<{ | |||
| trackAlertActionClicked: (alertKey: string) => void; | |||
There was a problem hiding this comment.
Minor, could we define a type for the track methods to avoid this duplication, such as AlertMetricsCallbacks?
|
Builds ready [2910775]
Page Load Metrics (1837 ± 120 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Sep 5, 2024
matthewwalsh0
approved these changes
Sep 5, 2024
metamaskbot
added
the
release-12.6.0
gauthierpetetin
added
release-12.5.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using context to get currently selected confirmation in re-designed confirmation pages. This is done to switch to using react context transient UI state in re-designed confirmation pages.
Related issues
Ref: #26414
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist