Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add integration test for gas estimate failed alert #26681

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Aug 27, 2024

Description

Adds an integration test to check the gas estimate failure alert

Open in GitHub Codespaces

Related issues

Fixes: #2972

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner August 27, 2024 12:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Aug 27, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [259fdde]
Page Load Metrics (71 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint811701052613
domContentLoaded4911066189
load5611471178
domInteractive125825115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 28 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (46bf4e8) to head (33a8897).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26681   +/-   ##
========================================
  Coverage    70.08%   70.08%           
========================================
  Files         1413     1413           
  Lines        49317    49317           
  Branches     13780    13780           
========================================
  Hits         34559    34559           
  Misses       14758    14758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnarayanaswamy pnarayanaswamy force-pushed the gas-estimate-failed-it-test branch from 152760e to 876efad Compare August 28, 2024 15:22
Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [33a8897]
Page Load Metrics (1586 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14101998159311756
domContentLoaded1403183715639345
load1411187615869847
domInteractive125931126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy merged commit 2f30256 into develop Aug 29, 2024
78 checks passed
@pnarayanaswamy pnarayanaswamy deleted the gas-estimate-failed-it-test branch August 29, 2024 06:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 29, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants