Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update moonbeam and moonriver network and token logos #26677

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Aug 27, 2024

Description

This PR updates the network and token logos for moonbeam and moonriver networks.

Open in GitHub Codespaces

Related issues

Fixes:
Related: #25267

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screen.Recording.2024-08-27.at.11.20.30.mov

After

Screen.Recording.2024-08-27.at.11.12.03.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner August 27, 2024 09:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (4ca92eb) to head (2bf7215).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26677   +/-   ##
========================================
  Coverage    70.09%   70.09%           
========================================
  Files         1413     1413           
  Lines        49254    49255    +1     
  Branches     13768    13768           
========================================
+ Hits         34523    34524    +1     
  Misses       14731    14731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM

Thanks for doing this

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Aug 27, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [2bf7215]
Page Load Metrics (80 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint791661102110
domContentLoaded4013274199
load4613280178
domInteractive95930136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sahar-fehri sahar-fehri merged commit 4d82374 into develop Aug 27, 2024
93 checks passed
@sahar-fehri sahar-fehri deleted the fix/moonbeam-moonriver-network-token-logos branch August 27, 2024 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 27, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants