-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Temporarily hide Approve redesigned pages #26676
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [afb6bd2]
Page Load Metrics (75 ± 7 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26676 +/- ##
========================================
Coverage 70.05% 70.05%
========================================
Files 1414 1414
Lines 49317 49320 +3
Branches 13780 13781 +1
========================================
+ Hits 34546 34549 +3
Misses 14771 14771 ☔ View full report in Codecov by Sentry. |
7eb0078
afb6bd2
to
7eb0078
Compare
6462ff7
7eb0078
to
6462ff7
Compare
Quality Gate passedIssues Measures |
Builds ready [6462ff7]
Page Load Metrics (85 ± 18 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Since we want to ship Approve, increaseAllowance and Revoke pages on the same release, we're holding off shipping the page for the Approve transaction type for the time being.
This is accomplished by creating two separate arrays
REDESIGN_USER_TRANSACTION_TYPES
andREDESIGN_DEV_TRANSACTION_TYPES
to control which transaction types are shown for the user feature toggle and for the developer settings toggle respectively.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3080
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist