Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Temporarily hide Approve redesigned pages #26676

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Aug 27, 2024

Description

Since we want to ship Approve, increaseAllowance and Revoke pages on the same release, we're holding off shipping the page for the Approve transaction type for the time being.

This is accomplished by creating two separate arrays REDESIGN_USER_TRANSACTION_TYPES and REDESIGN_DEV_TRANSACTION_TYPES to control which transaction types are shown for the user feature toggle and for the developer settings toggle respectively.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3080

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Aug 27, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Aug 27, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners August 27, 2024 09:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [afb6bd2]
Page Load Metrics (75 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64146103199
domContentLoaded4011670178
load4611675157
domInteractive9402574
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 56 Bytes (0.00%)
  • ui: -6 Bytes (-0.00%)
  • common: 87 Bytes (0.00%)

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (c3069ee) to head (6462ff7).
Report is 3 commits behind head on develop.

Files Patch % Lines
app/scripts/lib/transaction/metrics.ts 75.00% 1 Missing ⚠️
...ages/confirmations/hooks/useCurrentConfirmation.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26676   +/-   ##
========================================
  Coverage    70.05%   70.05%           
========================================
  Files         1414     1414           
  Lines        49317    49320    +3     
  Branches     13780    13781    +1     
========================================
+ Hits         34546    34549    +3     
  Misses       14771    14771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matthewwalsh0
matthewwalsh0 previously approved these changes Aug 27, 2024
vinistevam
vinistevam previously approved these changes Aug 28, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Aug 28, 2024
vinistevam
vinistevam previously approved these changes Aug 28, 2024
Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [6462ff7]
Page Load Metrics (85 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint863261195225
domContentLoaded51233823919
load58233853718
domInteractive126729136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 56 Bytes (0.00%)
  • ui: -10 Bytes (-0.00%)
  • common: 87 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo merged commit fb58241 into develop Aug 28, 2024
78 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/3080 branch August 28, 2024 15:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 28, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants