fix(snaps): Use ApprovalType instead DIALOG_APPROVAL_TYPES in confirmation page

[ritave]

Description

This PR uses proper constant from ApprovalType instead of DIALOG_APPROVAL_TYPES.

This required updating @metamask/controller-utils to ^11.1.0. I manually reviewed all breaking changes from controller-utils and found no breakages in the metamask-extension.

Related issues

Fixes MetaMask/core#4598

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected])

View full report↗︎

[ritave]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [91f63ce]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (75 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	179	103	25	12
		domContentLoaded	44	107	70	18	9
		load	51	107	75	17	8
		domInteractive	9	57	26	13	6

Bundle size diffs [🚀 Bundle size reduced!]

• background: -156.71 KiB (-4.34%)
• ui: 0 Bytes (0.00%)
• common: -273.85 KiB (-3.23%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (ee52d48) to head (91f63ce).
Report is 15 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26655      +/-   ##
===========================================
- Coverage    70.09%   70.09%   -0.00%     
===========================================
  Files         1413     1413              
  Lines        49254    49255       +1     
  Branches     13768    13768              
===========================================
  Hits         34524    34524              
- Misses       14730    14731       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.