Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky tests Sentry errors before initialization, after opting into metrics @no-mmi should capture UI application state... #26648

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Aug 26, 2024

Description

After looking into the Sentry tests, I've seen that sometimes they are flaky as there isn't enough time for the requests to happen, in these ocurrences:

          // Wait for Sentry request
          await driver.wait(async () => {
            const isPending = await mockedEndpoint.isPending();
            return isPending === false;
          }, 3000);

Being more conservative and increasing the wait time to 8000 makes test pass consistently as it has enough time to see the requests.

Open in GitHub Codespaces

Related issues

Fixes: #26536

Manual testing steps

  1. Check ci

Screenshots/Recordings

na

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner August 26, 2024 09:51
@seaona seaona self-assigned this Aug 26, 2024
@seaona seaona added team-extension-platform area-qa Relating to QA work (Quality Assurance) labels Aug 26, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (23aabcd) to head (fbae41b).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26648   +/-   ##
========================================
  Coverage    70.09%   70.09%           
========================================
  Files         1413     1413           
  Lines        49254    49254           
  Branches     13768    13768           
========================================
  Hits         34524    34524           
  Misses       14730    14730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [fbae41b]
Page Load Metrics (61 ± 5 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7010582105
domContentLoaded378157105
load438761105
domInteractive9272142
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@HowardBraham HowardBraham merged commit 5aeac0f into develop Aug 26, 2024
93 checks passed
@HowardBraham HowardBraham deleted the test-increase-wait-time-sentry branch August 26, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 26, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix "Sentry errors before initialization, after opting in..." flaky tests
5 participants