-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky tests Sentry errors before initialization, after opting into metrics @no-mmi should capture UI application state
...
#26648
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26648 +/- ##
========================================
Coverage 70.09% 70.09%
========================================
Files 1413 1413
Lines 49254 49254
Branches 13768 13768
========================================
Hits 34524 34524
Misses 14730 14730 ☔ View full report in Codecov by Sentry. |
Builds ready [fbae41b]
Page Load Metrics (61 ± 5 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix!
Description
After looking into the Sentry tests, I've seen that sometimes they are flaky as there isn't enough time for the requests to happen, in these ocurrences:
Being more conservative and increasing the wait time to
8000
makes test pass consistently as it has enough time to see the requests.Related issues
Fixes: #26536
Manual testing steps
Screenshots/Recordings
na
Pre-merge author checklist
Pre-merge reviewer checklist