Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allowlist Snap UI card component #26565

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Aug 21, 2024

Description

Fixes a problem where the Card component was not allowlisted for use in Snaps UI, the UI would crash when attempting to use this specific component.

Also tweaks the design of the Card component, aligning the image and handling cases where text could previously overflow.

Open in GitHub Codespaces

Screenshots/Recordings

Before

Crash

After

image

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Aug 21, 2024
@FrederikBolding FrederikBolding requested review from a team as code owners August 21, 2024 09:01
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 21, 2024
Copy link

@FrederikBolding FrederikBolding merged commit 6dc12d6 into develop Aug 21, 2024
85 of 86 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-snap-ui-card branch August 21, 2024 09:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 21, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ba0ee2a]
Page Load Metrics (73 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint65163982411
domContentLoaded43119692010
load4911973199
domInteractive106426126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 2.58 KiB (0.04%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants