-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: track swapAndSend
transaction type
#26535
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: app/scripts/lib/transaction/metrics.ts
Did you find this useful? React with a 👍 or 👎 |
f94bc23
to
66a76aa
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26535 +/- ##
========================================
Coverage 70.02% 70.03%
========================================
Files 1405 1405
Lines 49006 49021 +15
Branches 13703 13711 +8
========================================
+ Hits 34316 34328 +12
- Misses 14690 14693 +3 ☔ View full report in Codecov by Sentry. |
Builds ready [66a76aa]
Page Load Metrics (73 ± 6 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
The
swapAndSend
transaction event is casted to a contract interaction; this PR preserves the type.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist