Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track swapAndSend transaction type #26535

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

BZahory
Copy link
Contributor

@BZahory BZahory commented Aug 20, 2024

Description

The swapAndSend transaction event is casted to a contract interaction; this PR preserves the type.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@BZahory BZahory requested a review from a team as a code owner August 20, 2024 13:43
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sentry-io bot commented Aug 20, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/lib/transaction/metrics.ts

Function Unhandled Issue
buildEventFragmentProperties Error: Cannot read properties of undefined (reading 'gasPrice') buildEventFragmentProperties(app/scripts/lib/transact...
Event Count: 49 Affected Users: 0
buildEventFragmentProperties Error: e.txParams is undefined buildEventFragment...
Event Count: 2 Affected Users: 0
buildEventFragmentProperties Error: KeyringController - No keyring found. Error info: There are no keyrings MetamaskController.getAccountType(app/s...
Event Count: 1 Affected Users: 0

Did you find this useful? React with a 👍 or 👎

@BZahory BZahory force-pushed the swap-send-analytic-tx branch from f94bc23 to 66a76aa Compare August 20, 2024 17:25
Copy link

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.03%. Comparing base (e95ba94) to head (66a76aa).

Files Patch % Lines
ui/helpers/utils/metrics.js 83.33% 2 Missing ⚠️
app/scripts/lib/transaction/metrics.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26535   +/-   ##
========================================
  Coverage    70.02%   70.03%           
========================================
  Files         1405     1405           
  Lines        49006    49021   +15     
  Branches     13703    13711    +8     
========================================
+ Hits         34316    34328   +12     
- Misses       14690    14693    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [66a76aa]
Page Load Metrics (73 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7214299209
domContentLoaded549871136
load5810673136
domInteractive185328115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 112 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 936 Bytes (0.01%)

@BZahory BZahory merged commit 96b4475 into develop Aug 20, 2024
78 checks passed
@BZahory BZahory deleted the swap-send-analytic-tx branch August 20, 2024 21:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 20, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants