feat: account watcher e2e #26524

k-g-j · 2024-08-19T19:14:41Z

Description

This PR introduces end-to-end (E2E) tests for the account watcher feature. The tests cover the following scenarios:

Adding a watch account using a valid externally owned address (EOA).
Ensuring the “Send,” “Swap,” and “Bridge” buttons are disabled for watch accounts.
Handling various invalid inputs, such as missing prefixes, invalid addresses, and ENS names.
Preventing the import of private keys for watched addresses.
Verifying the absence of the “Show private key” button for watch accounts.
Removing and re-adding a watch account to validate proper account management.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/438

Manual testing steps

Build for test: yarn build:test
Run the new e2e: yarn test:e2e:single test/e2e/accounts/create-watch-account.spec.ts --browser=chrome --leave-running

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…s toggle

…atcher-snap # Conflicts: # app/scripts/snaps/preinstalled-snaps.ts # yarn.lock

… preinstalled snap

test/e2e/accounts/create-watch-account.spec.ts

codecov · 2024-08-20T18:31:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (c85cf5b) to head (8ea6344).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26524   +/-   ##
========================================
  Coverage    70.01%   70.01%           
========================================
  Files         1410     1410           
  Lines        49130    49130           
  Branches     13739    13739           
========================================
  Hits         34398    34398           
  Misses       14732    14732

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-08-20T18:43:33Z

Builds ready [e1b1b48]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (92 ± 10 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	177	122	24	12
		domContentLoaded	54	131	89	23	11
		load	61	131	92	21	10
		domInteractive	12	71	37	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 28.56 KiB (0.86%)
ui: 2.58 KiB (0.04%)
common: 350.3 KiB (4.46%)

metamaskbot · 2024-08-20T20:58:53Z

Builds ready [390483c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (77 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	136	101	17	8
		domContentLoaded	52	113	71	18	8
		load	59	113	77	16	8
		domInteractive	11	59	28	12	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/accounts/create-watch-account.spec.ts

sonarqubecloud · 2024-08-21T18:13:28Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-21T18:56:20Z

Builds ready [8ea6344]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (83 ± 13 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	195	112	33	16
		domContentLoaded	39	151	79	28	13
		load	46	151	83	27	13
		domInteractive	9	59	29	15	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-21T18:57:09Z

Builds ready [8ea6344]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (83 ± 13 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	195	112	33	16
		domContentLoaded	39	151	79	28	13
		load	46	151	83	27	13
		domInteractive	9	59	29	15	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

gantunesr

Good work

k-g-j and others added 30 commits August 13, 2024 16:03

feat: added AccountWatcher as preinstalled snap and added to menu list

51a5320

feat: put 'Watch Ethereum account (Beta)' behind experimental setting…

9293af3

…s toggle

Merge branch 'develop' into feat/add-account-watcher-snap

0497284

feat: renamed metric to 'WatchEthereumAccountsToggled'

6169fe0

Merge branch 'develop' into feat/add-account-watcher-snap

9aca5a6

fix: setupSentry state

9efcdff

Merge branch 'develop' into feat/add-account-watcher-snap

03a01d9

feat: updated copy and changed to eye icon

64c5b1c

Merge branch 'develop' into feat/add-account-watcher-snap

b14b0b0

Merge branch 'develop' into feat/add-account-watcher-snap

d0aab2f

Merge branch 'develop' into feat/add-account-watcher-snap

5789263

feat: updated account-watcher to 4.0.3

e08a9b1

Merge branch 'develop' into feat/add-account-watcher-snap

0c4d02b

feat: added width styling to the create-named-snap-account component

0f3e0e3

chore: updated snapshots

263d596

Merge branch 'develop' into feat/add-account-watcher-snap

9192883

Merge remote-tracking branch 'origin/develop' into feat/add-account-w…

d3238c4

…atcher-snap # Conflicts: # app/scripts/snaps/preinstalled-snaps.ts # yarn.lock

fix: merge conflicts with develop

ef465ff

feat: redirect to default route from back button on snap homepage for…

bdd38c8

… preinstalled snap

chore: yarn dedupe

fd8a1c3

feat: useCallback for 'handleAddWatchAccount'

4d963aa

Merge branch 'develop' into feat/add-account-watcher-snap

d89ac15

feat: added not removable to conditional in back button

217b60d

Merge branch 'develop' into feat/add-account-watcher-snap

38961fd

Merge branch 'develop' into feat/add-account-watcher-snap

e6c625e

Merge branch 'develop' into feat/add-account-watcher-snap

3296f93

feat: updated account-watcher to 4.1.0 with hidden flag

35c1736

Merge branch 'develop' into feat/add-account-watcher-snap

db054fd

Merge branch 'develop' into feat/add-account-watcher-snap

9674570

chore: update lavamoat

1bd6ac0

gantunesr reviewed Aug 20, 2024

View reviewed changes

test/e2e/accounts/create-watch-account.spec.ts Outdated Show resolved Hide resolved

k-g-j added 2 commits August 20, 2024 12:19

feat: updated test names to proper format

166e2fb

fix: lint

e1b1b48

k-g-j marked this pull request as ready for review August 20, 2024 19:57

k-g-j requested review from a team as code owners August 20, 2024 19:57

Merge branch 'develop' into feat/account-watcher-e2e

390483c

owencraston previously approved these changes Aug 20, 2024

View reviewed changes

gantunesr reviewed Aug 21, 2024

View reviewed changes

test/e2e/accounts/create-watch-account.spec.ts Show resolved Hide resolved

feat: added experimental settings tests

16dfd85

k-g-j dismissed owencraston’s stale review via 16dfd85 August 21, 2024 18:05

k-g-j and others added 2 commits August 21, 2024 14:05

Merge branch 'develop' into feat/account-watcher-e2e

d2e17e4

feat: updated test descriptions

8ea6344

owencraston approved these changes Aug 21, 2024

View reviewed changes

gantunesr approved these changes Aug 21, 2024

View reviewed changes

k-g-j merged commit 187da88 into develop Aug 21, 2024
78 checks passed

k-g-j deleted the feat/account-watcher-e2e branch August 21, 2024 19:14

github-actions bot locked and limited conversation to collaborators Aug 21, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 21, 2024

gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: account watcher e2e #26524

feat: account watcher e2e #26524

k-g-j commented Aug 19, 2024 •

edited

Loading

codecov bot commented Aug 20, 2024 •

edited

Loading

metamaskbot commented Aug 20, 2024

metamaskbot commented Aug 20, 2024

sonarqubecloud bot commented Aug 21, 2024

metamaskbot commented Aug 21, 2024

metamaskbot commented Aug 21, 2024

gantunesr left a comment

feat: account watcher e2e #26524

feat: account watcher e2e #26524

Conversation

k-g-j commented Aug 19, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

codecov bot commented Aug 20, 2024 • edited Loading

Codecov Report

metamaskbot commented Aug 20, 2024

metamaskbot commented Aug 20, 2024

sonarqubecloud bot commented Aug 21, 2024

Quality Gate passed

metamaskbot commented Aug 21, 2024

metamaskbot commented Aug 21, 2024

gantunesr left a comment

Choose a reason for hiding this comment

k-g-j commented Aug 19, 2024 •

edited

Loading

codecov bot commented Aug 20, 2024 •

edited

Loading