fix: Flaky contract interaction test

[pedronfigueiredo]

Description

On #26234, scrollAndConfirmAndAssertConfirm was modified to use clickElementSafe instead of clickElement.

Even though this was probably useful for the test in snap-account-contract-interaction.spec.ts that the PR introduced, it broke Sends a contract interaction type 2 transaction with custom nonce editing (EIP1559) inside contract-interaction-redesign.spec.ts. This is because clickElementSafe doesn't attempt to find a clickable element multiple times like clickElement. Without that retry, the scroll button was not pressed. Without that, the confirm button in the footer was not enabled and the test fails.

Adding a delay before the particular usage of scrollAndConfirmAndAssertConfirm that was failing fixes the test execution.

Related issues

Fixes: #26417

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[hjetpoluru]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (e644e1d) to head (d173af1).

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #26420       +/-   ##
============================================
+ Coverage         0   69.97%   +69.97%     
============================================
  Files            0     1422     +1422     
  Lines            0    49938    +49938     
  Branches         0    13861    +13861     
============================================
+ Hits             0    34943    +34943     
- Misses           0    14995    +14995     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [d173af1]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (692 ± 416 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	370	113	61	29
		domContentLoaded	10	85	21	17	8
		load	44	2301	692	865	416
		domInteractive	10	85	21	17	8

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)