Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notifications use better events #26410

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Aug 14, 2024

Description

This PR updates and introduces some events necessary for the notifications team to track user interaction with notifications.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Aug 14, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matteoscurati matteoscurati changed the title Fix/notifications use better events fix: notifications use better events Aug 14, 2024
@matteoscurati matteoscurati marked this pull request as ready for review August 14, 2024 09:24
@matteoscurati matteoscurati requested a review from a team as a code owner August 14, 2024 09:24
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.15%. Comparing base (b3c2323) to head (fbeb7d7).
Report is 5 commits behind head on develop.

Files Patch % Lines
...i/components/multichain/global-menu/global-menu.js 0.00% 1 Missing ⚠️
...boarding-flow/privacy-settings/privacy-settings.js 50.00% 1 Missing ⚠️
...ty-tab/profile-sync-toggle/profile-sync-toggle.tsx 66.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26410      +/-   ##
===========================================
+ Coverage    70.13%   70.15%   +0.02%     
===========================================
  Files         1435     1435              
  Lines        50309    50350      +41     
  Branches     13897    13919      +22     
===========================================
+ Hits         35283    35321      +38     
- Misses       15026    15029       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [fbeb7d7]
Page Load Metrics (132 ± 148 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64290954823
domContentLoaded892232010
load391469132309148
domInteractive892232010
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 1.35 KiB (0.02%)
  • common: -66 Bytes (-0.00%)

Copy link

@matteoscurati matteoscurati merged commit 92eb990 into develop Aug 14, 2024
75 of 76 checks passed
@matteoscurati matteoscurati deleted the fix/notifications-use-better-events branch August 14, 2024 12:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [520a2c3]
Page Load Metrics (453 ± 371 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681681062211
domContentLoaded106922136
load472348453773371
domInteractive106922136
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 1.35 KiB (0.02%)
  • common: -66 Bytes (-0.00%)

@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants