Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve hex copy button #26384

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix: Improve hex copy button #26384

merged 4 commits into from
Aug 14, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Aug 13, 2024

Description

This PR leverages the copy behaviour introduced in the InfoRow component in #25682 to update the design for copying hex data in the transaction advanced details.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2024-08-13 at 11 20 34

After

Screenshot 2024-08-13 at 11 12 45

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Aug 13, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Aug 13, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner August 13, 2024 10:21
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title fix: hex copy btn fix: Improve hex copy button Aug 13, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Aug 13, 2024
Copy link

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (b3c2323) to head (c42e207).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26384      +/-   ##
===========================================
+ Coverage    70.13%   70.15%   +0.02%     
===========================================
  Files         1435     1435              
  Lines        50309    50337      +28     
  Branches     13897    13918      +21     
===========================================
+ Hits         35283    35312      +29     
+ Misses       15026    15025       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c42e207]
Page Load Metrics (153 ± 175 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint683411135527
domContentLoaded95421136
load411733153364175
domInteractive95421136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -1.33 KiB (-0.02%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo merged commit 3c89610 into develop Aug 14, 2024
78 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/fix-copy-btn branch August 14, 2024 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 14, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants