refactor(notifications): use contentful package as dev dependency

[Prithpal-Sooriya]

Description

We only use this package for its types, so can be treated as a dev dependency. This will also resolve the audit issue currently seen in CI.

Related issues

Fixes: CI issues, and better reflects the use case of this dependency.

Manual testing steps

Re-test notifications flow

1. Onboard with new or existing wallet
2. Enable notifications
3. Perform a swap on Polygon (a chain we support on-chain notifications for)
4. See if notifications appear.

For Notification Devs: As there is no feature announcements yet, manually change the code to point to a portfolio feature announcement. I've tested and it seems that we still correctly show a feature announcement to users.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected]	None	0	229 kB	ljharb

🚮 Removed packages: npm/[email protected]

View full report↗︎

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Prithpal-Sooriya]

I have moved this from "dependencies" to "dev-dependencies". We only use this package for its types, so we don't strictly need this in our builds.

[Prithpal-Sooriya]

As this is now a dev dependency, it also resolves the yarn audit issues surrounding axios.

[matteoscurati]

LGTM

[metamaskbot]

Builds ready [2606849]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (284 ± 255 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	123	96	15	7
		domContentLoaded	8	52	23	12	6
		load	42	1577	284	531	255
		domInteractive	8	52	23	12	6

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (1fef871) to head (2606849).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26381   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1434     1434           
  Lines        50285    50285           
  Branches     13890    13890           
========================================
  Hits         35259    35259           
  Misses       15026    15026           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.4.0), as PR was cherry-picked in branch 12.2.0.