fix: adding warning for origin on redesigned pages #26306

jpuri · 2024-08-02T11:59:19Z

Description

Adding origin related validation in all redesigned confirmation pages.

Related issues

NA

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-08-02T11:59:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sunobun · 2024-08-06T19:58:48Z

Into my wallet

sunobun · 2024-08-06T20:00:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

My wallet

…ension into add_origin_warning

ui/pages/confirmations/components/confirm/info/personal-sign/personal-sign.tsx

matthewwalsh0 · 2024-08-14T09:09:55Z

ui/hooks/useAlerts.ts

@@ -37,8 +37,10 @@ const useAlerts = (ownerId: string) => {
      if (!field) {
        return [];
      }
-
-      return alerts.filter((alert) => alert.field === field);
+      const fields = field.split(',');


Following my other comment about alert keys, this logic shouldn't be needed as every field should have a single alert key, and multiple alerts can reference it.

I fixed it.

app/_locales/en/messages.json

...ges/confirmations/components/confirm/info/shared/transaction-details/transaction-details.tsx

ui/pages/confirmations/hooks/alerts/useConfirmationOriginAlerts.ts

matthewwalsh0 · 2024-08-14T09:19:21Z

ui/pages/confirmations/hooks/alerts/useConfirmationOriginAlerts.ts

+        ],
+      },
+    ];
+  }, [currentConfirmation, t]);


Rather than returning a fresh object every time the confirmation changes at all, could we instead use the most stable dependencies possible such as isInvalidAscii, field and t?

It also simplifies the code since we can move the core logic out of the useMemo.

ui/pages/confirmations/utils/confirm.ts

digiwand

I agree with @matthewwalsh0 that we should update the alertKey values to represent the field references.

Renaming the existing props, as mentioned in a thread above, may be out of scope of this PR and could be followed up separately

ui/pages/confirmations/utils/confirm.ts

ui/pages/confirmations/utils/confirm.test.ts

ui/pages/confirmations/utils/confirm.ts

…ension into add_origin_warning

metamaskbot · 2024-08-16T10:36:28Z

Builds ready [2f8bafd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (916 ± 645 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	379	137	86	41
		domContentLoaded	9	105	33	25	12
		load	48	4635	916	1343	645
		domInteractive	9	105	33	25	12

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.68 KiB (0.04%)
common: 680 Bytes (0.01%)

codecov · 2024-08-16T10:37:17Z

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.97%. Comparing base (81af2e8) to head (501302a).
Report is 12 commits behind head on develop.

Files	Patch %	Lines
ui/pages/confirmations/utils/confirm.ts	60.00%	4 Missing ⚠️
...tions/confirmation/templates/add-ethereum-chain.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26306      +/-   ##
===========================================
+ Coverage    69.96%   69.97%   +0.01%     
===========================================
  Files         1405     1406       +1     
  Lines        48996    49019      +23     
  Branches     13697    13702       +5     
===========================================
+ Hits         34280    34299      +19     
- Misses       14716    14720       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ui/pages/confirmations/hooks/alerts/useConfirmationOriginAlerts.ts

metamaskbot · 2024-08-19T13:03:38Z

Builds ready [b76e671]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (264 ± 266 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	291	119	59	28
		domContentLoaded	11	53	26	10	5
		load	50	2201	264	554	266
		domInteractive	11	53	26	10	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.76 KiB (0.05%)
common: 695 Bytes (0.01%)

sonarqubecloud · 2024-08-20T09:14:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-20T09:44:16Z

Builds ready [501302a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (91 ± 25 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	399	117	68	33
		domContentLoaded	48	299	86	54	26
		load	54	299	91	53	25
		domInteractive	12	90	32	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.76 KiB (0.05%)
common: 695 Bytes (0.01%)

jpuri added 2 commits August 2, 2024 17:25

Show warning on redesigned pages if origin has special characters

4e7bf90

Show warning on redesigned pages if origin has special characters

cc7594a

jpuri added the team-confirmations Push issues to confirmations team label Aug 2, 2024

update

8ece60e

jpuri added 11 commits August 13, 2024 16:43

Merge branch 'develop' into add_origin_warning

94101b7

Merge branch 'add_origin_warning' of github.com:MetaMask/metamask-ext…

4dec32b

…ension into add_origin_warning

update

94f039e

update

8359c67

update

4087e33

update

76cbbcf

Merge branch 'develop' into add_origin_warning

5298cd4

update

04c51c3

Merge branch 'add_origin_warning' of github.com:MetaMask/metamask-ext…

58a6c05

…ension into add_origin_warning

Merge branch 'develop' into add_origin_warning

d6754b0

Merge branch 'add_origin_warning' of github.com:MetaMask/metamask-ext…

75f64c8

…ension into add_origin_warning

jpuri marked this pull request as ready for review August 13, 2024 15:50

jpuri requested review from a team as code owners August 13, 2024 15:50

jpuri added 2 commits August 13, 2024 21:30

update

a529909

update

eefda43

matthewwalsh0 requested changes Aug 14, 2024

View reviewed changes

digiwand requested changes Aug 14, 2024

View reviewed changes

digiwand reviewed Aug 14, 2024

View reviewed changes

ui/pages/confirmations/utils/confirm.ts Outdated Show resolved Hide resolved

digiwand reviewed Aug 14, 2024

View reviewed changes

ui/pages/confirmations/utils/confirm.test.ts Show resolved Hide resolved

digiwand reviewed Aug 14, 2024

View reviewed changes

ui/pages/confirmations/utils/confirm.ts Show resolved Hide resolved

jpuri added 2 commits August 15, 2024 21:19

merge

429c4cc

Update

f665393

jpuri requested a review from matthewwalsh0 August 15, 2024 16:13

jpuri added 3 commits August 15, 2024 21:47

update

df804dd

Merge branch 'add_origin_warning' of github.com:MetaMask/metamask-ext…

53be467

…ension into add_origin_warning

update

2f8bafd

digiwand previously approved these changes Aug 16, 2024

View reviewed changes

matthewwalsh0 requested changes Aug 16, 2024

View reviewed changes

update

61caead

jpuri dismissed digiwand’s stale review via 61caead August 19, 2024 10:36

jpuri requested review from matthewwalsh0 and digiwand August 19, 2024 10:38

matthewwalsh0 previously approved these changes Aug 19, 2024

View reviewed changes

update

bce48ab

jpuri dismissed matthewwalsh0’s stale review via bce48ab August 19, 2024 12:00

jpuri requested a review from matthewwalsh0 August 19, 2024 12:01

update

b76e671

jpuri added 2 commits August 20, 2024 14:16

merge

050865e

update

501302a

digiwand approved these changes Aug 20, 2024

View reviewed changes

matthewwalsh0 approved these changes Aug 20, 2024

View reviewed changes

jpuri merged commit 5f524f1 into develop Aug 21, 2024
78 checks passed

jpuri deleted the add_origin_warning branch August 21, 2024 04:25

github-actions bot locked and limited conversation to collaborators Aug 21, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 21, 2024

gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: adding warning for origin on redesigned pages #26306

fix: adding warning for origin on redesigned pages #26306

jpuri commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 2, 2024

sunobun commented Aug 6, 2024

sunobun commented Aug 6, 2024

Quality Gate passed

matthewwalsh0 Aug 14, 2024

jpuri Aug 15, 2024

matthewwalsh0 Aug 14, 2024

digiwand left a comment

metamaskbot commented Aug 16, 2024

codecov bot commented Aug 16, 2024 •

edited

Loading

metamaskbot commented Aug 19, 2024

sonarqubecloud bot commented Aug 20, 2024

metamaskbot commented Aug 20, 2024

fix: adding warning for origin on redesigned pages #26306

fix: adding warning for origin on redesigned pages #26306

Conversation

jpuri commented Aug 2, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Aug 2, 2024

sunobun commented Aug 6, 2024

sunobun commented Aug 6, 2024

Quality Gate passed

matthewwalsh0 Aug 14, 2024

Choose a reason for hiding this comment

jpuri Aug 15, 2024

Choose a reason for hiding this comment

matthewwalsh0 Aug 14, 2024

Choose a reason for hiding this comment

digiwand left a comment

Choose a reason for hiding this comment

metamaskbot commented Aug 16, 2024

codecov bot commented Aug 16, 2024 • edited Loading

Codecov Report

metamaskbot commented Aug 19, 2024

sonarqubecloud bot commented Aug 20, 2024

Quality Gate passed

metamaskbot commented Aug 20, 2024

jpuri commented Aug 2, 2024 •

edited

Loading

codecov bot commented Aug 16, 2024 •

edited

Loading