Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Polish multichain token list styles #26300

Merged
merged 27 commits into from
Aug 23, 2024
Merged

chore: Polish multichain token list styles #26300

merged 27 commits into from
Aug 23, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Aug 1, 2024 •
edited by github-actions bot
Loading

Description

Bump Avatar Network marginRight to 16px
Tweak top & bottom padding on AssetList item
Bump border width on AvatarBase and set to default background
Convert stakeableTitle to in-line rather than Flexbox to avoid incosistent padding
Bump font weight on Stake button to match token title
Update snapshots

Open in GitHub Codespaces

Related issues

Fixes: MMASSETS-328

Manual testing steps

  1. Go to token listing with several tokens
  2. Verify that styles matches direction given in [Design Quality]: Update multichain token list item and view #26187

Screenshots/Recordings

Screenshot 2024-08-01 at 2 37 28 PM Screenshot 2024-08-01 at 2 38 36 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Aug 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4f53c6b]
Page Load Metrics (386 ± 308 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6551314811455
domContentLoaded9113282412
load402011386641308
domInteractive9113282412
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 65 Bytes (0.00%)
  • common: 10 Bytes (0.00%)

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (800a9d3) to head (fd3c3b7).
Report is 1 commits behind head on develop.

Files Patch % Lines
...pp/import-token/token-list/token-list.component.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26300      +/-   ##
===========================================
- Coverage    70.10%   70.09%   -0.01%     
===========================================
  Files         1413     1413              
  Lines        49257    49254       -3     
  Branches     13769    13768       -1     
===========================================
- Hits         34529    34524       -5     
- Misses       14728    14730       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gambinish gambinish marked this pull request as ready for review August 1, 2024 22:16
@gambinish gambinish requested review from a team as code owners August 1, 2024 22:16
@metamaskbot
Copy link
Collaborator

Builds ready [be1befe]
Page Load Metrics (311 ± 270 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint673011367637
domContentLoaded9131283015
load401710311563270
domInteractive9131283015
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -126 Bytes (-0.00%)
  • common: -58 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ce838ef]
Page Load Metrics (252 ± 267 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7313498167
domContentLoaded105924147
load471959252556267
domInteractive105924147
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -126 Bytes (-0.00%)
  • common: -58 Bytes (-0.00%)

@gambinish gambinish requested a review from bergeron August 2, 2024 20:09
@metamaskbot
Copy link
Collaborator

Builds ready [cbabd33]
Page Load Metrics (70 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6613696189
domContentLoaded4610665147
load5310670147
domInteractive105425105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -68 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall
chore: adding storybook for token-list moving avatar network updates …
be4ed7d 
…to token list and replacing some css for style utility props
@georgewrmarshall georgewrmarshall force-pushed the chore/mmassets-328_polish-multichain-token-list-styles branch from 2762b7b to be4ed7d Compare August 23, 2024 22:12
georgewrmarshall
georgewrmarshall approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Made some small adjustments to isolate the box sizing to the token item components. Hope that's ok! Really nice work 💯

@gambinish gambinish removed the request for review from a team August 23, 2024 22:48
@metamaskbot
Copy link
Collaborator

Builds ready [dae0ccf]
Page Load Metrics (63 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6911787136
domContentLoaded45775894
load51866394
domInteractive16422373
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 238 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [fd3c3b7]
Page Load Metrics (95 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint901741272411
domContentLoaded6113293199
load7213395199
domInteractive187337147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 238 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish merged commit 0a96c7d into develop Aug 23, 2024
78 checks passed
@gambinish gambinish deleted the chore/mmassets-328_polish-multichain-token-list-styles branch August 23, 2024 23:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 23, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@bergeron bergeron bergeron approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gambinish @metamaskbot @garrettbear @bergeron @georgewrmarshall @amandaye0h @gauthierpetetin