fix: handle send transaction API errors

[BZahory]

Description

We are seeing a pair of sentry errors for a failing deconstruction error, Cannot destructure property 'id' of '(intermediate value)' as it is null:

• https://metamask.sentry.io/issues/5093909594/?project=273505&query=is%3Aunresolved+Cannot+destructure+property+%27id%27+of&referrer=issue-stream&statsPeriod=14d&stream_index=0
• https://metamask.sentry.io/issues/5093909594/?project=273505&query=is%3Aunresolved+Cannot+destructure+property+%27id%27+of&referrer=issue-stream&statsPeriod=14d&stream_index=0

This is because instead of returning an error when a transaction fails, we return null for the metadata.

This PR addresses the underlying issue by rethrowing the error for a failed transaction request, then adding UI treatments for the failed transaction.

Related issues

Fixes:

Manual testing steps

1. Add an Error right before the sendTransaction background method in addTransactionAndRouteToConfirmationPage
2. Go to the send flow
3. Attempt a basic send
4. Ensure that the page does not crash and the transactionErrored copy is shown

Screenshots/Recordings

Before

Screen.Recording.2024-07-31.at.12.26.52.PM.mov

After

Screen.Recording.2024-07-31.at.12.25.46.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [9d401b9]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (389 ± 299 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	313	120	61	29
		domContentLoaded	8	175	35	36	17
		load	40	1812	389	622	299
		domInteractive	8	175	35	36	17

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 408 Bytes (0.01%)
• common: 8 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.94%. Comparing base (2beba47) to head (8d99049).

Files	Patch %	Lines
ui/components/multichain/pages/send/send.js	7.69%	12 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26253      +/-   ##
===========================================
- Coverage    69.95%   69.94%   -0.00%     
===========================================
  Files         1411     1411              
  Lines        49963    49972       +9     
  Branches     13800    13801       +1     
===========================================
+ Hits         34948    34952       +4     
- Misses       15015    15020       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [8d99049]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (71 ± 16 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	225	107	31	15
		domContentLoaded	10	111	22	21	10
		load	45	194	71	33	16
		domInteractive	10	111	22	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 410 Bytes (0.01%)
• common: 8 Bytes (0.00%)