-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add extra condition to prevent erroneous calls to fetch insight #26248
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26248 +/- ##
===========================================
- Coverage 69.95% 69.95% -0.00%
===========================================
Files 1411 1411
Lines 49963 49963
Branches 13800 13800
===========================================
- Hits 34948 34947 -1
- Misses 15015 15016 +1 ☔ View full report in Codecov by Sentry. |
Builds ready [05b94d2]
Page Load Metrics (223 ± 239 ms)
Bundle size diffs
|
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
undefined
parameters for a signature insight call, it was found that this was reproducible when a signature request was rejected.fetchInsight
in theuseSignatureInsights
hook.Pre-merge author checklist
Pre-merge reviewer checklist