test: snap account contract interaction #26234

plasmacorral · 2024-07-30T19:51:01Z

Description

This PR will introduce an e2e test for a snap account interacting with a contract via the test dapp.

Related issues

Fixes: 470

Manual testing steps

yarn build:test:mv2 then ENABLE_MV3=false yarn test:e2e:single test/e2e/accounts/snap-account-contract-interaction.spec.ts --browser=firefox
yarn build:test then yarn test:e2e:single test/e2e/accounts/snap-account-contract-interaction.spec.ts --browser=chrome

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-30T19:51:14Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-08-02T21:44:22Z

Builds ready [ec5bed6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (75 ± 24 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	251	112	53	26
		domContentLoaded	9	117	35	35	17
		load	38	185	75	50	24
		domInteractive	9	117	35	35	17

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-08-02T21:44:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (b3c2323) to head (fd3ac1b).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26234   +/-   ##
========================================
  Coverage    70.13%   70.13%           
========================================
  Files         1435     1435           
  Lines        50309    50309           
  Branches     13897    13897           
========================================
  Hits         35283    35283           
  Misses       15026    15026

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-08-02T22:35:09Z

Builds ready [aaf9fa7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (203 ± 248 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	173	121	25	12
		domContentLoaded	12	64	29	16	8
		load	45	2456	203	517	248
		domInteractive	12	64	29	16	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

plasmacorral · 2024-08-02T23:06:08Z

test/e2e/helpers.js

@@ -745,7 +745,7 @@ const PRIVATE_KEY =
  '0x7C9529A67102755B7E6102D6D950AC5D5863C98713805CEC576B945B15B71EAC';

 const PRIVATE_KEY_TWO =
-  '0xa444f52ea41e3a39586d7069cb8e8233e9f6b9dea9cbb700cce69ae860661cc8';
+  '0xf444f52ea41e3a39586d7069cb8e8233e9f6b9dea9cbb700cce69ae860661cc8';


Corrected the PRIVATE_KEY_TWO to ensure that we create the public address specified as ACCOUNT_2, rather than using public address 0x66ba6a97bf7e686c171cae1b754bca1521888dc1 (which is what the a gave us.

test/e2e/accounts/snap-account-contract-interaction.spec.ts

metamaskbot · 2024-08-12T15:44:04Z

Builds ready [e1b9d41]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (464 ± 399 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	500	134	109	52
		domContentLoaded	9	297	39	63	30
		load	43	2835	464	830	399
		domInteractive	9	297	39	63	30

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-13T16:29:06Z

Builds ready [a682167]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (241 ± 250 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	141	104	18	9
		domContentLoaded	10	66	25	15	7
		load	42	1984	241	522	250
		domInteractive	9	66	25	15	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Co-authored-by: Gustavo Antunes <[email protected]>

sonarqubecloud · 2024-08-13T20:12:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-13T21:46:52Z

Builds ready [fd3ac1b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (71 ± 10 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	149	107	19	9
		domContentLoaded	10	71	26	18	9
		load	42	124	71	21	10
		domInteractive	10	71	26	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-13T21:47:09Z

Builds ready [fd3ac1b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (71 ± 10 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	149	107	19	9
		domContentLoaded	10	71	26	18	9
		load	42	124	71	21	10
		domInteractive	10	71	26	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

plasmacorral added team-accounts e2e-test End to end test for the MetaMask extension labels Jul 30, 2024

plasmacorral self-assigned this Jul 30, 2024

plasmacorral marked this pull request as ready for review August 2, 2024 22:59

plasmacorral requested a review from a team as a code owner August 2, 2024 22:59

plasmacorral added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 2, 2024

plasmacorral commented Aug 2, 2024

View reviewed changes

owencraston previously approved these changes Aug 2, 2024

View reviewed changes

gantunesr reviewed Aug 12, 2024

View reviewed changes

test/e2e/accounts/snap-account-contract-interaction.spec.ts Outdated Show resolved Hide resolved

test/e2e/accounts/snap-account-contract-interaction.spec.ts Show resolved Hide resolved

plasmacorral dismissed owencraston’s stale review via e1b9d41 August 12, 2024 15:13

plasmacorral force-pushed the test/snap-account-contract-interaction branch 2 times, most recently from 2c22a99 to a682167 Compare August 13, 2024 15:58

plasmacorral requested review from gantunesr and owencraston August 13, 2024 16:51

owencraston previously approved these changes Aug 13, 2024

View reviewed changes

plasmacorral dismissed owencraston’s stale review via 6b4e266 August 13, 2024 19:15

plasmacorral requested a review from owencraston August 13, 2024 19:18

plasmacorral added 7 commits August 13, 2024 16:09

add spec file

5713b86

snap not installed

803bd7b

new test

5252b96

Update test

5482929

Remove unused

e9144e6

fix confirm

0dfbf81

update helper

ab98fcf

plasmacorral and others added 9 commits August 13, 2024 16:09

update in case scroll is not shown

788688d

comments

c3a4b16

reorganize

3bfb266

Update test/e2e/accounts/snap-account-contract-interaction.spec.ts

b91dd2d

Co-authored-by: Gustavo Antunes <[email protected]>

check balance

080b094

update comment

f4076f5

clean up JSDoc

71589e7

update JSDoc

948f0c5

JSDoc update

fd3ac1b

plasmacorral force-pushed the test/snap-account-contract-interaction branch from 6b4e266 to fd3ac1b Compare August 13, 2024 20:10

owencraston approved these changes Aug 13, 2024

View reviewed changes

gantunesr approved these changes Aug 13, 2024

View reviewed changes

plasmacorral merged commit 50949f8 into develop Aug 13, 2024
78 checks passed

plasmacorral deleted the test/snap-account-contract-interaction branch August 13, 2024 21:52

plasmacorral removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 13, 2024

github-actions bot locked and limited conversation to collaborators Aug 13, 2024

metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 13, 2024

gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: snap account contract interaction #26234

test: snap account contract interaction #26234

plasmacorral commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024

metamaskbot commented Aug 2, 2024

codecov bot commented Aug 2, 2024 •

edited

Loading

metamaskbot commented Aug 2, 2024

plasmacorral Aug 2, 2024 •

edited

Loading

metamaskbot commented Aug 12, 2024

metamaskbot commented Aug 13, 2024

sonarqubecloud bot commented Aug 13, 2024

metamaskbot commented Aug 13, 2024

metamaskbot commented Aug 13, 2024

test: snap account contract interaction #26234

test: snap account contract interaction #26234

Conversation

plasmacorral commented Jul 30, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 30, 2024

metamaskbot commented Aug 2, 2024

codecov bot commented Aug 2, 2024 • edited Loading

Codecov Report

metamaskbot commented Aug 2, 2024

plasmacorral Aug 2, 2024 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Aug 12, 2024

metamaskbot commented Aug 13, 2024

sonarqubecloud bot commented Aug 13, 2024

Quality Gate passed

metamaskbot commented Aug 13, 2024

metamaskbot commented Aug 13, 2024

plasmacorral commented Jul 30, 2024 •

edited

Loading

codecov bot commented Aug 2, 2024 •

edited

Loading

plasmacorral Aug 2, 2024 •

edited

Loading