Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [Page Object Model] rename process to flow #26228

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Jul 30, 2024

Description

Following the previous discussions on adopting best practices for the Page Object Model (POM) within our e2e testing framework, I've made some updates to reflect the merged best practices in contributor-docs.

The key change is to replace the term "processes" with "flows" to more accurately and intuitively describe sequences of user interactions.
Additionally, this PR corrects a typo in the function name loginWithBalanceValidation.

Reason for Replacing "Process" with "Flow": The term "flows" more effectively captures the sequences of user interactions we're automating in our e2e tests. By making this change, we aim to reduce confusion and enhance clarity, thereby making our test codebase more intuitive for future adoption of page object model.

Open in GitHub Codespaces

Related issues

Fixes: #24986

Manual testing steps

  1. E2E tests should pass in pipeline

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue added team-extension-platform area-qa Relating to QA work (Quality Assurance) labels Jul 30, 2024
@chloeYue chloeYue self-assigned this Jul 30, 2024
@chloeYue chloeYue requested a review from a team as a code owner July 30, 2024 15:53
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue marked this pull request as draft July 30, 2024 15:53
@chloeYue chloeYue changed the title [DRAFT][POM]rename process to flow test: [DRAFT][POM]rename process to flow Jul 30, 2024
Copy link

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (aceea3b) to head (bbb20d2).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26228   +/-   ##
========================================
  Coverage    69.96%   69.96%           
========================================
  Files         1411     1411           
  Lines        49946    49946           
  Branches     13805    13805           
========================================
  Hits         34942    34942           
  Misses       15004    15004           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [bbb20d2]
Page Load Metrics (166 ± 209 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint721691002311
domContentLoaded10104232110
load452060166435209
domInteractive10104232110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue changed the title test: [DRAFT][POM]rename process to flow test: [Page Object Model] rename process to flow Jul 31, 2024
@chloeYue chloeYue marked this pull request as ready for review July 31, 2024 09:52
@chloeYue chloeYue merged commit 6e29b88 into develop Jul 31, 2024
95 of 96 checks passed
@chloeYue chloeYue deleted the pom-rename-process branch July 31, 2024 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 31, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[POM] Define best practices for POM implementation and add it in contributor doc
5 participants