-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [Page Object Model] rename process to flow #26228
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26228 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1411 1411
Lines 49946 49946
Branches 13805 13805
========================================
Hits 34942 34942
Misses 15004 15004 ☔ View full report in Codecov by Sentry. |
Builds ready [bbb20d2]
Page Load Metrics (166 ± 209 ms)
Bundle size diffs
|
Description
Following the previous discussions on adopting best practices for the Page Object Model (POM) within our e2e testing framework, I've made some updates to reflect the merged best practices in contributor-docs.
The key change is to replace the term "processes" with "flows" to more accurately and intuitively describe sequences of user interactions.
Additionally, this PR corrects a typo in the function name
loginWithBalanceValidation
.Reason for Replacing "Process" with "Flow": The term "flows" more effectively captures the sequences of user interactions we're automating in our e2e tests. By making this change, we aim to reduce confusion and enhance clarity, thereby making our test codebase more intuitive for future adoption of page object model.
Related issues
Fixes: #24986
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist