chore: add wallet state injection and yarn start:with-state script
#26222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26222 +/- ##
===========================================
- Coverage 70.02% 69.90% -0.12%
===========================================
Files 1443 1450 +7
Lines 50162 50249 +87
Branches 14039 14046 +7
===========================================
Hits 35124 35124
- Misses 15038 15125 +87 ☔ View full report in Codecov by Sentry. |
Builds ready [dabdb0f]
Page Load Metrics (231 ± 230 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [3ffe5c6]
Page Load Metrics (155 ± 182 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [14c8f4c]
Page Load Metrics (89 ± 9 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
commented
Aug 19, 2024
test/e2e/fixture-builder.js
Outdated
| const { toHex } = require('@metamask/controller-utils'); | ||
| const { NetworkStatus } = require('@metamask/network-controller'); | ||
|
|
||
| const { CHAIN_IDS, NETWORK_TYPES } = require('../../shared/constants/network'); | ||
| const { SMART_CONTRACTS } = require('./seeder/smart-contracts'); | ||
| const { DAPP_URL, DAPP_ONE_URL, ACCOUNT_1 } = require('./helpers'); |
There was a problem hiding this comment.
instead of using the variables from the helpers file, we now use them from the constants file.
This change was needed in this PR since otherwise we get an error because the test environment variables in the helpers file are not defined (which is expected as we don't run any test environment with the wallet state functionality, but we do need the fixture-builder methods)
seaona
commented
Aug 19, 2024
| @@ -145,7 +145,7 @@ env: | |||
| # The unlock password | |||
| - PASSWORD: null | |||
| - TEST_SRP: null | |||
| - SKIP_ONBOARDING: null | |||
There was a problem hiding this comment.
we changed this to a more generic name, as the feature is expanded to handle more wallet state data, than just skipping the onboarding
seaona
commented
Aug 19, 2024
| firstTimeState = { ...firstTimeState, ...skipOnboardingStateOverrides }; | ||
| if (process.env.WITH_STATE) { | ||
| const stateOverrides = await generateWalletState(); | ||
| firstTimeState = { ...firstTimeState, ...stateOverrides }; | ||
| } |
There was a problem hiding this comment.
we changed this variable names, as the skip onboarding feature is expanded to handle more wallet state data, than just skipping the onboarding
Builds ready [e793540]
Page Load Metrics (74 ± 9 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [3e9ddff]
Page Load Metrics (75 ± 8 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [dd598ba]
Page Load Metrics (67 ± 7 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Hi @seaona , i tested on your branch, i encountered a issue that the ERC20 tokens are not displayed, not sure what's the problem, could you have a look? Thanks ! Screen.Recording.2024-09-06.at.14.25.50.mov |
whoaa nice catch 😍 thank you @chloeYue ! the logic for substituting the account address was not correct, so it was appearing only in mine since the address was hardcoded. Now it should be fixed |
Builds ready [27c2962]
Page Load Metrics (1739 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Test ok on latest commit, ERC20 tokens are displayed:
|
hjetpoluru
previously approved these changes
Sep 11, 2024
HowardBraham
dismissed stale reviews from hjetpoluru and chloeYue
via
db85677
HowardBraham
force-pushed
the
wallet-state-injection
branch
from
18c5c39 to
46bd784
Compare
|
Builds ready [46bd784]
Page Load Metrics (1742 ± 86 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hjetpoluru
approved these changes
Sep 18, 2024
chloeYue
approved these changes
Sep 18, 2024
|
Test OK on the latest branch status ! |
HowardBraham
approved these changes
Sep 18, 2024
metamaskbot
added
the
release-12.6.0
metamaskbot
added
release-12.5.0
|
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, we add a new script that you can use to build the wallet in dev mode with a preloaded state.
Default Fixtures:
yarn start:with-state- should load a wallet with the SRP and password set in the metamaskrc file, with several controllers data (contacts, transactions, notifications...) defined in the fixtures-flags file.Terminal Help:
yarn start:with-state --helpto see the available fixture flags to customizeCustom Fixtures:
yarn start:with-state --withAccounts=12 --withContacts=13with-state-final.mp4
Future Work:
This sets the base for adding and customizing more wallet state. We can expand this as much as we want. Here are the listed possible future tasks:
Related issues
Fixes:
Manual testing steps
Check main functionality:
PASSWORDand aTEST_SRPto your metamaskrc fileyarn start:with-state===============================
Check flags validation:
yarn start:with-state --help===============================
Check custom fixtures:
yarn start:with-state --withErc20Tokens=false --withXYZ=123 ...Screenshots/Recordings
Above
Pre-merge author checklist
Pre-merge reviewer checklist