Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update copy right info for ledger #26221

Closed
wants to merge 2 commits into from

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented Jul 30, 2024

New ledger will not have blind signing option in their settings, and Ledger team has us to remove the copy right information.

image

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/540

Manual testing steps

  1. pair your ledger with MM extension.
  2. open a metamask.github.io/test-dapp, and connect to your ledger account
  3. fire a Send EIP 1559 Transaction transaction.
  4. Check the transaction instruction screen not showing test in above image.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
@dawnseeker8 dawnseeker8 deleted the feat/update-copy-right-info-for-ledger branch September 13, 2024 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants