Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PPOM blockaid update #26154

Merged
merged 3 commits into from
Jul 26, 2024
Merged

fix: PPOM blockaid update #26154

merged 3 commits into from
Jul 26, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jul 26, 2024

Description

Update @blockaid/ppom_release package to version 1.5.1

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2889

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jul 26, 2024
@jpuri jpuri requested review from a team as code owners July 26, 2024 10:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/[email protected] network 0 3.36 MB blockaiduser

🚮 Removed packages: npm/@blockaid/[email protected]

View full report↗︎

Copy link

@jpuri jpuri changed the title feat: PPOM blockaid update fix: PPOM blockaid update Jul 26, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [2692d91]
Page Load Metrics (288 ± 330 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711791062512
domContentLoaded106029157
load412943288687330
domInteractive106029157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.94%. Comparing base (b27dd2b) to head (2692d91).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26154   +/-   ##
========================================
  Coverage    69.94%   69.94%           
========================================
  Files         1409     1409           
  Lines        49794    49794           
  Branches     13773    13773           
========================================
  Hits         34826    34826           
  Misses       14968    14968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri merged commit ffa8677 into develop Jul 26, 2024
84 checks passed
@jpuri jpuri deleted the ppom_blockaid_update branch July 26, 2024 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 26, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants