Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor outStream end-handling #26142

Merged
merged 3 commits into from
Jul 25, 2024
Merged

fix: refactor outStream end-handling #26142

merged 3 commits into from
Jul 25, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jul 25, 2024 •
edited
Loading

Targeting: #26141

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 25, 2024
@legobeat legobeat force-pushed the fix-setupControllerConnection-outstream-end-refactor branch from 0002e9b to 12a02df Compare July 25, 2024 19:45
@legobeat legobeat requested a review from danjm July 25, 2024 19:46
@legobeat legobeat changed the title fix setupControllerConnection outstream end refactor fix: refactor outStream end-handling Jul 25, 2024
@legobeat legobeat force-pushed the fix-setupControllerConnection-outstream-end-refactor branch 5 times, most recently from 8d7e23b to a72af0a Compare July 25, 2024 20:44
@legobeat legobeat force-pushed the fix-setupControllerConnection-outstream-end-refactor branch 2 times, most recently from 8ce9af3 to c1d5b01 Compare July 25, 2024 21:29
@legobeat legobeat force-pushed the fix-setupControllerConnection-outstream-end-refactor branch from c1d5b01 to fe44d80 Compare July 25, 2024 21:34
@legobeat legobeat marked this pull request as ready for review July 25, 2024 21:34
@legobeat legobeat requested a review from a team as a code owner July 25, 2024 21:34
@legobeat legobeat mentioned this pull request Jul 25, 2024
Merged
7 tasks
@legobeat legobeat merged commit fe44d80 into MetaMask:fix-setupControllerConnection-outstream-end Jul 25, 2024
58 of 66 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @danjm @metamaskbot