-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add extra event props #26123
chore: Add extra event props #26123
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added extra event properties related to hardware wallets for enhanced MetaMetrics tracking.
app/scripts/metamask-controller.js
: AddedgetMetaMetricsProps
function to retrieve hardware wallet details.package.json
: Updated@metamask/smart-transactions-controller
dependency to version^11.0.0
.shared/modules/selectors/index.ts
: Imported and exportedgetHardwareWalletType
for broader access.ui/ducks/swaps/swaps.js
: Addedis_hardware_wallet
andhardware_wallet_type
properties to swap events.shared/constants/metametrics.ts
: Updated MetaMetrics event names to include hardware wallet details.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
LGTM! |
@metamaskbot update-policies |
Policies updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Added extra event properties related to hardware wallets for enhanced MetaMetrics tracking and improved type safety across the codebase.
test/e2e/tests/confirmations/alerts/queued-confirmations.spec.ts
: Introduced end-to-end tests for queued confirmations, covering both old and redesigned flows.ui/pages/confirmations/components/confirm/info/row/text-token-units.tsx
: Added a new component for formatting and displaying token amounts with precision.ui/pages/confirmations/hooks/alerts/transactions/useQueuedConfirmationsAlerts.ts
: Introduced a custom hook for generating alerts for queued confirmations.ui/pages/institutional/confirm-add-custodian-token/confirm-add-custodian-token.tsx
: Converted from JavaScript to TypeScript, enhancing type safety and maintainability.ui/pages/confirmations/components/signature-request-original/signature-request-original.component.js
: AddedQueuedRequestsBannerAlert
component to enhance user awareness of pending actions.
69 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Added extra event properties related to hardware wallets for enhanced MetaMetrics tracking and improved type safety across the codebase.
lavamoat/browserify/beta/policy.json
: Added new package dependencies and global variables, includinguuid
and@metamask/rpc-errors
.lavamoat/browserify/flask/policy.json
: Introduceduuid
package and new global variablesTextDecoder
andTextEncoder
.lavamoat/browserify/main/policy.json
: Updated to includeuuid
,@metamask/rpc-errors
, and other packages for hardware wallet event properties.lavamoat/browserify/mmi/policy.json
: Enableduuid
,@metamask/rpc-errors
, and additional packages for hardware wallet support.
Ensure thorough testing to verify compatibility and security.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [aefc9df]
Page Load Metrics (84 ± 23 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26123 +/- ##
===========================================
- Coverage 69.94% 69.93% -0.01%
===========================================
Files 1409 1409
Lines 49794 49802 +8
Branches 13773 13773
===========================================
Hits 34826 34826
- Misses 14968 14976 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Added extra event properties related to hardware wallets for enhanced MetaMetrics tracking and improved type safety across the codebase.
app/scripts/metamask-controller.js
: Integrated new propertiesaccountHardwareType
,accountType
, anddeviceModel
into eventsSTX Swap Started
,STX Status Updated
, andSTX Confirmed
.package.json
: Updated@metamask/smart-transactions-controller
dependency to version^11.0.0
.shared/modules/selectors/index.ts
: Added and exportedgetHardwareWalletType
selector.ui/components/multichain/network-list-item/network-list-item.js
: IntroducedstartAccessory
andshowEndAccessory
props for enhanced component customization.ui/ducks/swaps/swaps.js
: Addedis_hardware_wallet
andhardware_wallet_type
properties to swaps smart transaction process.
Ensure thorough testing to verify compatibility and security.
10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [66142ed]
Page Load Metrics (205 ± 270 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Quality Gate passedIssues Measures |
Builds ready [34fd2b2]
Page Load Metrics (80 ± 16 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Adds extra event props related to HW wallets, which are already used in multiple other events.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist