-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate global unit tests from Mocha to Jest #26104
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [e6eea7c]
Page Load Metrics (336 ± 299 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26104 +/- ##
========================================
Coverage 69.94% 69.94%
========================================
Files 1409 1409
Lines 49795 49795
Branches 13773 13773
========================================
Hits 34826 34826
Misses 14969 14969 ☔ View full report in Codecov by Sentry. |
Builds ready [060d93c]
Page Load Metrics (224 ± 228 ms)
Bundle size diffs
|
LGTM ! |
Description
This PR converts the global unit tests from Mocha to Jest. It removes the
test-unit-global
CircleCI pipeline and runs the global unit tests on GitHub actions along with the normal unit tests, contributing to the coverage report.Upon discussion with @Gudahtt the ignored dysfunctional unit test
test/unit-global/protect-intrinsics.test.js
which was not compatible with the Jest environment will be re-introduced in a separate PR. The test will be ported to run as part of the e2e test suite, as the browser would be a better test environment, closer to production.Related issues
Fixes: #25496
Manual testing steps
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist