-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lock Chrome version to 126 #26101
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Temporarily locked the Chrome version to 126 to address issues with Chrome 127 on CircleCI.
- Modified
test/e2e/webdriver/chrome.js
to set the Chrome version to 126. - Ensures stability in the CI environment by avoiding issues with Chrome 127.
- No security issues or logical errors introduced.
- This is a temporary fix and should be revisited once Chrome 127 issues are resolved.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [3e1060b]
Page Load Metrics (222 ± 216 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26101 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 1405 1405
Lines 49728 49728
Branches 13748 13748
========================================
+ Hits 34645 34646 +1
+ Misses 15083 15082 -1 ☔ View full report in Codecov by Sentry. |
Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.0.0. |
Description
Chrome version 127 is causing problems on CircleCI. This temporarily locks the Chrome version to 126.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist