Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock Chrome version to 126 #26101

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: lock Chrome version to 126 #26101

merged 1 commit into from
Jul 24, 2024

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Jul 24, 2024

Description

Chrome version 127 is causing problems on CircleCI. This temporarily locks the Chrome version to 126.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@HowardBraham HowardBraham self-assigned this Jul 24, 2024
@HowardBraham HowardBraham requested a review from a team as a code owner July 24, 2024 18:08
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Temporarily locked the Chrome version to 126 to address issues with Chrome 127 on CircleCI.

  • Modified test/e2e/webdriver/chrome.js to set the Chrome version to 126.
  • Ensures stability in the CI environment by avoiding issues with Chrome 127.
  • No security issues or logical errors introduced.
  • This is a temporary fix and should be revisited once Chrome 127 issues are resolved.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [3e1060b]
Page Load Metrics (222 ± 216 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701421022411
domContentLoaded96925178
load411575222451216
domInteractive96925178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (3d2a436) to head (3e1060b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26101   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1405     1405           
  Lines        49728    49728           
  Branches     13748    13748           
========================================
+ Hits         34645    34646    +1     
+ Misses       15083    15082    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru hjetpoluru merged commit 335c497 into develop Jul 24, 2024
85 of 86 checks passed
@hjetpoluru hjetpoluru deleted the chrome-126 branch July 24, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@metamaskbot metamaskbot added release-12.3.0 Issue or pull request that will be included in release 12.3.0 release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Jul 24, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.0.0 on PR. Adding release label release-12.0.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.0.0.

@HowardBraham HowardBraham added contributor experience An issue that impacts, or planned improvement to, the contributor experience. and removed team-contributor-experience labels Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-12.0.0 Issue or pull request that will be included in release 12.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants