Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: (cherry-pick) Remove special reject button case from api spec tests (#26048) (#26051)" #26094

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jul 24, 2024

This reverts commit 6b875da from PR #26051

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner July 24, 2024 13:32
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Reverted the removal of the special reject button case in API spec tests to ensure accurate simulation of user interactions for specific methods.

  • Modified test/e2e/api-specs/ConfirmationRejectionRule.ts to reintroduce handling for personal_sign and eth_signTypedData_v4.
  • Added a private array rejectButtonInsteadOfCancel to manage methods requiring the 'Reject' button.
  • Updated the afterRequest method to click 'Reject' instead of 'Cancel' for specified methods.
  • Ensure the 'Reject' button is always present and clickable for these methods to avoid test failures.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (Version-v12.2.0@6b875da). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             Version-v12.2.0   #26094   +/-   ##
==================================================
  Coverage                   ?   69.96%           
==================================================
  Files                      ?     1390           
  Lines                      ?    48919           
  Branches                   ?    13460           
==================================================
  Hits                       ?    34226           
  Misses                     ?    14693           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digiwand digiwand closed this Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants