Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated Ux for Switching Via Dapp (Missing Network) - Custom Chain Id #26087

Closed
wants to merge 9 commits into from

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Jul 24, 2024

This PR is to update the UI when the dapp tries to add custom Chain Id network in MetaMask

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2661

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jul 24, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 24, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.1% Duplication on New Code (required ≤ 7%)

See analysis details on SonarCloud

@NidhiKJha NidhiKJha closed this Sep 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants