Migrate confirm-add-custodian-token to TypeScript #26080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The confirm-add-custodian-token component, its Storybook, and tests have been migrated to TypeScript, enhancing type safety and maintainability.
- Storybook Migration:
ui/pages/institutional/confirm-add-custodian-token/confirm-add-custodian-token.stories.tsxupdated to TypeScript, introducing aCustomDatainterface for type safety. - Test Migration:
ui/pages/institutional/confirm-add-custodian-token/confirm-add-custodian-token.test.tsconverted to TypeScript, ensuring type safety in test scenarios. - Component Migration:
ui/pages/institutional/confirm-add-custodian-token/confirm-add-custodian-token.tsxmigrated to TypeScript, with type annotations added for props, state, functions, and variables.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -0,0 +1,159 @@ | |||
| import { ComponentType } from 'react'; | |||
There was a problem hiding this comment.
Style: import { RenderResult } from '@testing-library/react' is unused and can be removed.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Migrate confirm-add-custodian-token to TypeScript
Description:
This PR includes the migration of the
confirm-add-custodian-tokencomponent and its associated Storybook and tests to TypeScript, following the project's standards for TypeScript components. The changes ensure that the component, its stories, and tests are now fully typed according to TypeScript best practices.Link to Devin run: https://preview.devin.ai/devin/0a5ba332049042ab85c118677a94e810
Requested by: Albert