Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flaky test Account Custom Name.. #26062

Merged
merged 11 commits into from
Jul 24, 2024
Merged

fix: Flaky test Account Custom Name.. #26062

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cece0a8
Replaced the clickElement to clickElementAndWaitToDisappear
hjetpoluru Jul 23, 2024
29e824d
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Jul 23, 2024
c3e2521
linting
plasmacorral Jul 23, 2024
793bd84
Fixed lint
hjetpoluru Jul 23, 2024
62f8c64
Merge branch 'fix-flaky-test-custom-name' of github.com:MetaMask/meta…
hjetpoluru Jul 23, 2024
3eba1d9
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Jul 23, 2024
015dcde
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Jul 24, 2024
5827df4
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Jul 24, 2024
81b5d2b
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Jul 24, 2024
cb671da
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Jul 24, 2024
429068f
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
hjetpoluru Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/e2e/accounts/account-custom-name.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ describe('Account Custom Name Persistence', function (this: Suite) {
'[data-testid="multichain-account-menu-popover-add-account"]',
);
await driver.fill('[placeholder="Account 2"]', anotherAccountLabel);
await driver.clickElement({ text: 'Create', tag: 'button' });
await driver.clickElementAndWaitToDisappear({
text: 'Create',
tag: 'button',
});
await locateAccountBalanceDOM(driver);

// Verify initial custom account label after freshly added account was active
Expand Down