Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Migration #122 set redesignedConfirmationsEnabled to tr… #26047

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jul 23, 2024

…ue (#25769)"

This reverts commit 3ec4b1e.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested review from a team as code owners July 23, 2024 14:00
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 23, 2024
Copy link

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request reverts the previous commit that enabled redesigned confirmations by default.

  • Removed redesignedConfirmationsEnabled from Sentry: app/scripts/lib/setupSentry.js
  • Deleted migration and test files: app/scripts/migrations/122.ts and app/scripts/migrations/122.test.ts
  • Updated migration index: Removed migration 122 from app/scripts/migrations/index.js
  • Simplified E2E tests: Removed tempToggleSettingRedesignedConfirmations from multiple test files
  • Modified error message: Simplified error message in test/e2e/webdriver/driver.js

19 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@digiwand
Copy link
Contributor Author

nvm! no need as fix is underway

@digiwand digiwand closed this Jul 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants