fix: Flaky "Signature Approved Event" e2e test

[digiwand]

Description

Fixes flaky "Signature Approved Event" tests by awaiting a click event

Related issues

Fixes: #26036

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[greptile-apps]

PR Summary

Fixes flaky "Signature Approved Event" e2e tests by ensuring click events are awaited properly.

• Modified test/e2e/helpers.js to replace direct element clicks with await driver.clickElement.
• Ensures click actions are completed before proceeding, reducing race conditions.
• Enhances test stability, particularly for 'Signature Approved Event'.
• No significant security issues or logical errors introduced.
• Changes are consistent with existing codebase patterns.

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[seaona]

LGTM! great finding 😍

[digiwand]

Thanks for the driver.clickElement() > click() suggestion @seaona!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (9395988) to head (8a8e325).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26040   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1404     1404           
  Lines        49682    49682           
  Branches     13726    13726           
========================================
  Hits         34614    34614           
  Misses       15068    15068           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [8a8e325]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (74 ± 10 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	141	101	19	9
		domContentLoaded	10	65	30	16	8
		load	45	121	74	20	10
		domInteractive	10	65	30	16	8

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)