Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for IconButton component #26032

Closed
wants to merge 1 commit into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 23, 2024

Description

The IconButton component in the MetaMask extension lacked a story for isolated UI testing and documentation. This pull request introduces a story for the IconButton component, following the Storybook.js format, to facilitate better testing and development practices.

Related issues

  • None

Manual testing steps

  • Manual testing was not possible due to unrelated errors in the Storybook build process that prevented the Storybook UI from launching.

Screenshots/Recordings

  • Screenshots are not available as the Storybook UI could not be launched due to unrelated errors.

Pre-merge author checklist

  • I've followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I've included tests if applicable.
  • I've documented my code using JSDoc format if applicable.
  • I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot added the team-design-system All issues relating to design system in Extension label Jul 23, 2024
Copy link

@metamaskbot metamaskbot added the team-ai AI team (for the Devin AI bot) label Jul 23, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 23, 2024 22:24
@georgewrmarshall
Copy link
Contributor

Duplicate

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants