-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove password manager mention #25985
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me!
Builds ready [8de1297]
Page Load Metrics (398 ± 352 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
…MetaMask/metamask-extension into remove-password-manager-mention
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25985 +/- ##
========================================
Coverage 69.98% 69.98%
========================================
Files 1409 1409
Lines 49856 49856
Branches 13779 13779
========================================
Hits 34887 34887
Misses 14969 14969 ☔ View full report in Codecov by Sentry. |
Builds ready [ae9058f]
Page Load Metrics (138 ± 152 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
ui/pages/onboarding-flow/secure-your-wallet/secure-your-wallet.js
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Builds ready [ba1b465]
Page Load Metrics (325 ± 289 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
In the onboarding for the Secret Recovery Phrase we suggest backing up to a password manager, which we now want to change.
This PR should now remove this bullet point mention. I've also re-ordered the previous 2nd and 3rd bullet points for this quick fix as I thought it odd to start with the advice to store the Secret Recovery Phrase in a safety deposit box.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/529
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist