Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove password manager mention #25985

Merged
merged 11 commits into from
Jul 30, 2024
Merged

Conversation

AlexJupiter
Copy link
Contributor

@AlexJupiter AlexJupiter commented Jul 19, 2024

Description

In the onboarding for the Secret Recovery Phrase we suggest backing up to a password manager, which we now want to change.

This PR should now remove this bullet point mention. I've also re-ordered the previous 2nd and 3rd bullet points for this quick fix as I thought it odd to start with the advice to store the Secret Recovery Phrase in a safety deposit box.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/529

Manual testing steps

  1. Onboard to MetaMask
  2. Setup a new Secret Recovery Phrase

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@AlexJupiter AlexJupiter added team-accounts Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Jul 19, 2024
@AlexJupiter AlexJupiter requested a review from coreyjanssen July 19, 2024 16:39
@AlexJupiter AlexJupiter marked this pull request as ready for review July 19, 2024 16:44
@AlexJupiter AlexJupiter requested a review from a team as a code owner July 19, 2024 16:44
coreyjanssen
coreyjanssen previously approved these changes Jul 19, 2024
Copy link
Contributor

@coreyjanssen coreyjanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me!

@gantunesr gantunesr changed the title Remove password manager mention refactor: remove password manager mention Jul 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8de1297]
Page Load Metrics (398 ± 352 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732291223316
domContentLoaded10152403316
load442555398734352
domInteractive10152403316
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -219 Bytes (-0.00%)
  • common: -71 Bytes (-0.00%)

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (f53dc06) to head (ba1b465).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25985   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1409     1409           
  Lines        49856    49856           
  Branches     13779    13779           
========================================
  Hits         34887    34887           
  Misses       14969    14969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [ae9058f]
Page Load Metrics (138 ± 152 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint663491075828
domContentLoaded106829178
load411515138316152
domInteractive106829178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -225 Bytes (-0.00%)
  • common: -74 Bytes (-0.00%)

@danroc
Copy link
Contributor

danroc commented Jul 23, 2024

Tested:

image

But I left a minor comment.

Copy link

@gantunesr gantunesr self-assigned this Jul 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ba1b465]
Page Load Metrics (325 ± 289 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint772011113115
domContentLoaded105924147
load431803325602289
domInteractive105924147
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -254 Bytes (-0.00%)
  • common: -74 Bytes (-0.00%)

@danroc
Copy link
Contributor

danroc commented Jul 30, 2024

Tested again:

image

LGTM

@danroc danroc merged commit 7d079ed into develop Jul 30, 2024
76 checks passed
@danroc danroc deleted the remove-password-manager-mention branch July 30, 2024 07:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 30, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
@k-g-j
Copy link
Contributor

k-g-j commented Sep 12, 2024

Tested in Chrome version 128.0.6613.138
Copy matches expected ✅
Screenshot 2024-09-12 at 4 48 54 PM

Tested in Firefox version 130.0
Copy matches expected ✅
Screenshot 2024-09-12 at 4 52 33 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants