-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: MMI-5248 introduce the token allowance functionality for MMI #25967
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Builds ready [bd414b2]
Page Load Metrics (72 ± 10 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25967 +/- ##
===========================================
- Coverage 69.75% 69.69% -0.06%
===========================================
Files 1400 1400
Lines 49419 49482 +63
Branches 13668 13687 +19
===========================================
+ Hits 34470 34482 +12
- Misses 14949 15000 +51 ☔ View full report in Codecov by Sentry. |
@@ -222,6 +237,43 @@ export default function TokenAllowance({ | |||
}); | |||
}; | |||
|
|||
///: BEGIN:ONLY_INCLUDE_IF(build-mmi) | |||
const mmiApprovalFlow = () => { | |||
if (accountType === 'custody') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Consider using an enum for accountType
values to centralize and standardize.
Same for custodyStatus = 'created'
.
Description
Adds code fences to enable the token allowance functionality for MMI by following the correct flow.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist