Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MMI-5248 introduce the token allowance functionality for MMI #25967

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

zone-live
Copy link
Contributor

Description

Adds code fences to enable the token allowance functionality for MMI by following the correct flow.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested review from a team as code owners July 19, 2024 09:58
@zone-live zone-live added the team-mmi PRs from the MMI team label Jul 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [bd414b2]
Page Load Metrics (72 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671441012110
domContentLoaded106026126
load41117722110
domInteractive106026126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -20 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 69.69%. Comparing base (15cd69d) to head (bd414b2).
Report is 20 commits behind head on develop.

Files Patch % Lines
...s/confirmations/token-allowance/token-allowance.js 17.39% 19 Missing ⚠️
...s/confirmations/confirm-approve/confirm-approve.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25967      +/-   ##
===========================================
- Coverage    69.75%   69.69%   -0.06%     
===========================================
  Files         1400     1400              
  Lines        49419    49482      +63     
  Branches     13668    13687      +19     
===========================================
+ Hits         34470    34482      +12     
- Misses       14949    15000      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -222,6 +237,43 @@ export default function TokenAllowance({
});
};

///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
const mmiApprovalFlow = () => {
if (accountType === 'custody') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Consider using an enum for accountType values to centralize and standardize.
Same for custodyStatus = 'created'.

@zone-live zone-live merged commit 922e0f8 into develop Jul 22, 2024
79 checks passed
@zone-live zone-live deleted the MMI-5248-re-introduce-spending-cap branch July 22, 2024 08:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants