Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Removed step from e2e tests #25910

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

davibroc
Copy link
Contributor

@davibroc davibroc commented Jul 17, 2024

The following Enhanced Transaction Protection modal has been removed from onboarding steps so I also had to remove the step from the e2e test automation script

Screenshot 2024-07-17 at 10 14 06 PM

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@davibroc davibroc self-assigned this Jul 17, 2024
@davibroc davibroc requested a review from a team as a code owner July 17, 2024 20:21
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.75%. Comparing base (5f0949b) to head (05740eb).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25910   +/-   ##
========================================
  Coverage    69.75%   69.75%           
========================================
  Files         1400     1400           
  Lines        49419    49419           
  Branches     13668    13668           
========================================
  Hits         34469    34469           
  Misses       14950    14950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [05740eb]
Page Load Metrics (465 ± 336 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722931084622
domContentLoaded10492284
load462178465701336
domInteractive10492284
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@davibroc davibroc merged commit 0919647 into develop Jul 17, 2024
89 checks passed
@davibroc davibroc deleted the fix/trans-protection-dlg-removal branch July 17, 2024 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 17, 2024
@metamaskbot metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Aug 28, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants