Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove abandoned test:unit:jest command #25905

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Jul 17, 2024

Description

Open in GitHub Codespaces

This PR removes the abandoned and non-existent test:unit:jest command from the test command. The test:unit:jest was removed earlier in #25726, but it was accidentally left in as part of the test command.

Related issues

Fixes: None

Manual testing steps

  1. running yarn test should run successfully, and it should not error with script cannot be found.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Jul 17, 2024
@itsyoboieltr itsyoboieltr requested a review from a team as a code owner July 17, 2024 15:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [05befda]
Page Load Metrics (413 ± 329 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732591113919
domContentLoaded997312010
load441913413686329
domInteractive997312010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru merged commit 5083774 into develop Jul 18, 2024
78 of 79 checks passed
@hjetpoluru hjetpoluru deleted the fix-abandoned-test-unit-jest branch July 18, 2024 02:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants