Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-organize files under assets folder #25897

Merged
merged 9 commits into from
Jul 18, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jul 17, 2024

Description

Re-organize assets files under assets folder

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets labels Jul 17, 2024
@sahar-fehri sahar-fehri marked this pull request as ready for review July 17, 2024 14:21
@sahar-fehri sahar-fehri requested review from a team as code owners July 17, 2024 14:21
bergeron
bergeron previously approved these changes Jul 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [52a4f0d]
Page Load Metrics (187 ± 209 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint752111273216
domContentLoaded117331157
load422086187436209
domInteractive117331157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 2.43 KiB (0.03%)
  • common: 0 Bytes (0.00%)

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [853b084]
Page Load Metrics (152 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint762841174220
domContentLoaded97832178
load501464152304146
domInteractive97832178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 2.45 KiB (0.03%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (bc25508) to head (853b084).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25897   +/-   ##
========================================
  Coverage    69.71%   69.71%           
========================================
  Files         1400     1400           
  Lines        49462    49462           
  Branches     13691    13691           
========================================
  Hits         34478    34478           
  Misses       14984    14984           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahar-fehri sahar-fehri merged commit 322b7ed into develop Jul 18, 2024
79 checks passed
@sahar-fehri sahar-fehri deleted the fix/reorganize-assets-files branch July 18, 2024 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants