Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disables "swap and send" for MMI #25886

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

zone-live
Copy link
Contributor

Description

We need to disable the Swap & Send functionality for MMI, as we don't support the swaps flow in MM.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added team-mmi PRs from the MMI team release-12.1.0 Issue or pull request that will be included in release 12.1.0 labels Jul 17, 2024
@zone-live zone-live requested a review from a team as a code owner July 17, 2024 10:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.76%. Comparing base (20f54db) to head (32a13d1).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25886      +/-   ##
===========================================
- Coverage    69.76%   69.76%   -0.00%     
===========================================
  Files         1398     1400       +2     
  Lines        49171    49206      +35     
  Branches     13574    13580       +6     
===========================================
+ Hits         34303    34325      +22     
- Misses       14868    14881      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live requested a review from albertolive July 17, 2024 13:13
@metamaskbot
Copy link
Collaborator

Builds ready [32a13d1]
Page Load Metrics (232 ± 226 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint73143107209
domContentLoaded97131189
load451677232470226
domInteractive97131189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 18 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live changed the title fix: disables swap and send for MMI fix: disables "swap and send" for MMI Jul 17, 2024
@zone-live zone-live merged commit c12237f into develop Jul 17, 2024
82 checks passed
@zone-live zone-live deleted the MMI-5274-disable-swap-and-send-for-MMI branch July 17, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 17, 2024
@metamaskbot metamaskbot removed the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Aug 15, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-12.1.0) on PR and removing other release labels (release-12.3.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants