Added multichain api notifications

[shanejonas]

Description

Added multichain api notifications

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[greptile-apps]

PR Summary

Added multichain API notifications to enhance the handling of notifications across multiple blockchain networks.

• New Unit Tests: Added app/scripts/lib/multichain-api/multicainSubscriptionManager.test.ts for MultichainSubscriptionManager and createMultichainMiddlewareManager.
• Subscription Manager: Introduced app/scripts/lib/multichain-api/multichainSubscriptionManager.ts for managing multichain subscriptions and middleware.
• Provider Authorization: Updated app/scripts/lib/multichain-api/provider-authorize.js to handle multichain API notifications with new logging and scope management.
• Request Handling: Modified app/scripts/lib/multichain-api/provider-request.js to include a scope parameter for determining network client ID.
• Notification Support: Added eth_subscription to supported notifications in app/scripts/lib/multichain-api/scope/supported.ts.

_{8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

The recent changes focus on enhancing the multichain API notifications and managing subscriptions across different blockchain networks.

• Subscription Management: Introduced MultichainSubscriptionManager in app/scripts/lib/multichain-api/multichainSubscriptionManager.ts for handling subscriptions and notifications.
• Debug Logging: Added console logs in createMultichainMiddlewareManager for debugging, which should be replaced with a proper logging mechanism before production.
• Chain Change Notifications: Commented out _notifyChainChange in app/scripts/metamask-controller.js, potentially affecting chain change notifications. Thorough testing is recommended to ensure no regressions.

_{2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

The recent changes introduce multichain API notifications, enhancing the MetaMask extension's ability to handle notifications across different blockchain networks.

• New Class and Tests: Added app/scripts/lib/multichain-api/MultichainMiddlewareManager.ts and MultichainMiddlewareManager.test.ts to manage and test JSON-RPC middleware for different scopes and domains.
• Subscription Management: Updated app/scripts/lib/multichain-api/multichainSubscriptionManager.ts to improve multichain API notifications, including a new SubscriptionManager type and better subscription handling.
• Refactored Tests: Renamed and refocused app/scripts/lib/multichain-api/MultichainSubscriptionManager.test.ts to exclusively test MultichainSubscriptionManager.
• Logging Enhancements: Added error logging in app/scripts/lib/multichain-api/provider-authorize.js for better debugging during the authorization process.
• Controller Initialization: Simplified initialization in app/scripts/metamask-controller.js by directly instantiating MultichainMiddlewareManager and updating import paths.

_{6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@json-schema-tools/[email protected]	None	0	26.4 kB	belfordz
npm/@types/[email protected]	None	0	193 kB	types
npm/@types/[email protected]	None	0	44.9 kB	types
npm/@types/[email protected]	None	0	7.86 kB	types
npm/@typescript-eslint/[email protected]	None	0	223 kB	jameshenry
npm/@typescript-eslint/[email protected]	environment, filesystem	0	553 kB	jameshenry
npm/@typescript-eslint/[email protected]	None	0	18.4 kB	jameshenry
npm/[email protected]	environment, eval, filesystem, network	0	5.41 MB	contentful-ecosystem
npm/[email protected]	None	0	1.66 MB	davidlehn

🚮 Removed packages: npm/@json-schema-tools/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Network access	npm/[email protected]	Module: globalThis["fetch"] Location: Package overview	package.json yarn.lock	🚫
Network access	npm/[email protected]	Module: globalThis["fetch"] Location: Package overview	package.json yarn.lock	🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]

[shanejonas]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[adonesky1]

LGTM! Lets merge it