fix: flaky test Create BTC Account cannot create multiple BTC accounts...

[seaona]

Description

The Create BTC Account test is flaky as after clicking Create for creating a BTC account the popover remains some seconds visible, making that the subsequent click is obscured by it.
We fix this by using the clickElementAndWaitToDisappear method, which ensures that the popup is closed before proceeding.

driver] Called 'clickElement' with arguments [{"text":"Create","tag":"button"}]
[driver] Called 'delay' with arguments [500]
[driver] Called 'clickElement' with arguments ["[data-testid=\"account-menu-icon\"]"]
Failure on testcase: 'Create BTC Account cannot create multiple BTC accounts', for more information see the artifacts tab in CI

ElementClickInterceptedError: Element <button class="mm-box mm-text mm-button-base mm-button-base--size-sm mm-button-base--ellipsis multichain-account-picker mm-text--body-md-medium mm-text--ellipsis mm-box--padding-0 mm-box--padding-right-2 mm-box--padding-left-2 mm-box--display-inline-flex mm-box--gap-2 mm-box--justify-content-center mm-box--align-items-center mm-box--color-text-default mm-box--background-color-transparent mm-box--rounded-lg"> is not clickable at point (576,112) because another element <label class="mm-box mm-text mm-label mm-label--html-for mm-form-text-field__label mm-text--body-md mm-text--font-weight-medium mm-box--display-inline-flex mm-box--align-items-center mm-box--color-text-default"> obscures it


Executing testcase: 'Create BTC Account can cancel the removal of BTC acc

Related issues

Fixes: #25862

Manual testing steps

1. Check ci

Screenshots/Recordings

See artifacts, where the popup is still open

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[chloeYue]

LGTM ! Thanks for the quick fix !

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.77%. Comparing base (2d416bf) to head (963a758).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25861   +/-   ##
========================================
  Coverage    69.77%   69.77%           
========================================
  Files         1398     1398           
  Lines        49165    49165           
  Branches     13574    13574           
========================================
  Hits         34304    34304           
  Misses       14861    14861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [963a758]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (70 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	83	114	98	11	5
		domContentLoaded	10	60	29	15	7
		load	51	100	70	16	8
		domInteractive	10	60	29	15	7

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[hjetpoluru]

LGTM