fix: flaky test ERC721 NFTs testdapp interaction

[seaona]

Description

This PR fixes the flakiness of this specs due to how the window handling is managed in the spec file. When the test fails, we are in an invalidated context making the test flaky, when the current window is not correctly selected.
StaleElementReferenceError: stale element reference: stale element not found in the current frame

ci failure example: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/91382/workflows/70a1e3eb-3ff0-4e77-866a-fa2c4ed1d6ab/jobs/3407807/tests

Related issues

Fixes: #25855

Manual testing steps

1. Check ci

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[seaona]

changing this for switchToWindowWithTitle which has more advance logic with retrials to mitigate flakiness, so we can remove all the window management adhoc steps from the spec file:

const windowHandles = await driver.getAllWindowHandles();
const [extension] = windowHandles;

[seaona]

Having the extension window as a variable and keep referencing it steps later can cause the context to be invalidated. This is not recommended pattern and instead we should get the windows at the moment we want to switch to each of them

[metamaskbot]

Builds ready [a0fa95f]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (189 ± 235 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	300	110	49	24
		domContentLoaded	9	65	26	16	8
		load	40	2313	189	488	235
		domInteractive	9	65	26	16	8

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.77%. Comparing base (2d416bf) to head (a0fa95f).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25854   +/-   ##
========================================
  Coverage    69.77%   69.77%           
========================================
  Files         1398     1398           
  Lines        49165    49165           
  Branches     13574    13574           
========================================
  Hits         34304    34304           
  Misses       14861    14861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chloeYue]

LGTM ! Thanks for the quick fix !

[hjetpoluru]

LGTM